Pretty print #245
Open
Pretty print #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng: see tests_patterns, tests_tnsim and tests_transpiler
graphix/pattern.py
Outdated
|
|
||
| output.write(self.to_latex(left_to_right)) | ||
|
|
||
| output.write("\n\\end{document}") |
There was a problem hiding this comment.
Beware that \n is an escape form.
| """Return a string representation of the Circuit.""" | ||
| return self.draw() | ||
|
|
||
| def draw(self, output: str = "text") -> TextDrawing | matplotlib.figure | PIL.Image | str: |
There was a problem hiding this comment.
I don't understand your argument. I think it would be more efficient if you provided a direct code suggestion, assuming you believe it's worthwhile.
Co-authored-by: thierry-martinez <[email protected]>
…presenting pi in the proper format
|
if possible, can we move the implementation of drawing methods out of |
|
@benjvmin93 (CC: @shinich1 ) Additionally, if you're planning to add bunch of features to Are there any updates on |
added 7 commits
April 14, 2025 14:21
thierry-martinez
added a commit
to thierry-martinez/graphix
that referenced
this pull request
May 13, 2025
- Add dedicated pretty-printing functions for patterns. - Improve str() and repr() for circuits, patterns, and core data types (Sign, Axis, Plane, Command, Instruction). This is a focused extract from PR TeamGraphix#245, removing any external dependencies: - Render patterns as ASCII, Unicode, or LaTeX snippets (PDF/image output removed). - Provide evaluable representations for patterns, circuits, and other core types. Per Shinichi’s suggestion (TeamGraphix#245 (comment)), move most code from `pattern.py` into a new module `pretty_print.py`. Per EarlMilktea’s suggestion (TeamGraphix#245 (comment)), add type checking to `pretty_print.py` and its tests (`test_pretty_print.py`).
thierry-martinez
added a commit
to thierry-martinez/graphix
that referenced
this pull request
May 19, 2025
- Add dedicated pretty-printing functions for patterns. - Improve str() and repr() for circuits, patterns, and core data types (Sign, Axis, Plane, Command, Instruction). This is a focused extract from PR TeamGraphix#245, removing any external dependencies: - Render patterns as ASCII, Unicode, or LaTeX snippets (PDF/image output removed). - Provide evaluable representations for patterns, circuits, and other core types. Per Shinichi’s suggestion (TeamGraphix#245 (comment)), move most code from `pattern.py` into a new module `pretty_print.py`. Per EarlMilktea’s suggestion (TeamGraphix#245 (comment)), add type checking to `pretty_print.py` and its tests (`test_pretty_print.py`).
thierry-martinez
added a commit
that referenced
this pull request
May 21, 2025
* Pretty-print circuits and patterns - Add dedicated pretty-printing functions for patterns. - Improve str() and repr() for circuits, patterns, and core data types (Sign, Axis, Plane, Command, Instruction). This is a focused extract from PR #245, removing any external dependencies: - Render patterns as ASCII, Unicode, or LaTeX snippets (PDF/image output removed). - Provide evaluable representations for patterns, circuits, and other core types. Per Shinichi’s suggestion (#245 (comment)), move most code from `pattern.py` into a new module `pretty_print.py`. Per EarlMilktea’s suggestion (#245 (comment)), add type checking to `pretty_print.py` and its tests (`test_pretty_print.py`). * Fix use of `print_pattern` in examples * Add missing import * Update documentation * Update tutorial * Restore deprecated print_pattern and add arguments to converters * Add to CHANGELOG * Use `Iterable` in `Circuit.__init__` Suggested by EarlMilktea: #277 (comment) * Remove useless list collection before calling `join` Suggested by EarlMilktea: #277 (comment) * Use `Iterable` in `Pattern.__init__` and `Pattern.extend` Suggested by EarlMilktea: #277 (comment) * Use `enum.auto` instead of strings Suggested by EarlMilktea: #277 (comment) * Use the simpler `to_ascii` method in examples * Mixin for pretty-printing dataclasses * Mixin for pretty-printing Enum * Check instance of Enum in EnumMixin Suggested by EarlMilktea: #277 (comment) * Use `is not None` with `Iterable | None` EarlMilktea reported that Iterable does not implement __bool__. #277 (comment) * Annotate `self` with `DataclassInstance` Suggested by EarlMilktea: #277 (comment) * Fix ruff * Include `output_nodes` in `repr` * ruff fix with new linters * Fix swap and better code coverage * Use raw f-string Suggested by EarlMilktea: #277 (comment) * Update tutorial with `output_nodes` * Use `is not None` for `target` in `pattern_to_str` Reported by EarlMilktea: #277 (comment) * Add result type for `Circuit.__init__` Suggested by EarlMilktea: #277 (comment) * Rename `DataclassPrettyPrintMixin` and `EnumPrettyPrintMixin` Suggested by EarlMilktea: #277 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please check the following:
nox)ruffCONTRIBUTING.mdfor more detailsThen, please fill in below:
Context (if applicable):
#239
Description of the change:
New
draw()methods inCircuitandPatternclasses.Circuit.draw()generates the corresponding Qasm3 code and pass it toqiskit.draw()method. It relates on the same arguments (seeqiskit.draw()method documentation).pattern.draw()locally generates the appropriate visualization object (in the ascii, unicode, png, or latex formats)pattern.__repr__()returns the pythonic representation useful to initialize the same object. It involves handling__repr__method for commands. Thus, directly related to the writing of aclass Command.More details on the different changes are described in the
CHANGELOG.mdfile.Related issue: